Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SKU Price Details #497

Closed
1 task
jpradocueva opened this issue Jul 3, 2024 · 2 comments · Fixed by #503 or #530
Closed
1 task

SKU Price Details #497

jpradocueva opened this issue Jul 3, 2024 · 2 comments · Fixed by #503 or #530
Assignees
@shawnalpay @aqu-erp @kk09v
Labels
discussion topic Item or question to be discussed by the community sku details Attributes related to the SKU entity
Milestone
v1.1

Comments

@jpradocueva
Copy link
Contributor

jpradocueva commented Jul 3, 2024 •
edited
Loading

Lead Maintainer: Karl

Documents:

Description

This issue was created to host the following action item:

Proposed approach

Describe the approach that your group is proposing

Github issue or Reference

If the topic is related to a particular work item, reference the Github issue. If its a specification-wide topic, indicate that.

Context

Add any context that may help the community think through this and provide useful feedback
@jpradocueva jpradocueva added discussion topic Item or question to be discussed by the community P1 sku details Attributes related to the SKU entity labels Jul 3, 2024
@jpradocueva jpradocueva added this to the v1.1 milestone Jul 3, 2024
@github-project-automation github-project-automation bot moved this to Triage in FOCUS WG Jul 3, 2024
@jpradocueva jpradocueva moved this from Triage to W.I.P in FOCUS WG Jul 3, 2024
@jpradocueva
Copy link
Contributor Author

jpradocueva commented Jul 3, 2024 •
edited
Loading

New set of action items:

  • TF2-#497: Karl to incorporate the discussion points into a revised document and prepare a Pull Request (PR) by next week.
  • TF2-#497: Shawn to provide notes and feedback to Karl for the PR.
    Review and approve changes to column names and issue templates in upcoming meetings.

@jpradocueva jpradocueva changed the title SKU Price Details & Descriptions SKU Price Details Jul 4, 2024
@jpradocueva jpradocueva linked a pull request Jul 9, 2024 that will close this issue
FOCUS #497: SkuPriceDetails column #503
Merged
@jpradocueva
Copy link
Contributor Author

jpradocueva commented Jul 18, 2024 •
edited
Loading

Action items from TF-2, Jul 17 call:

  • TF2-#497 Karl to upload the structured JSON data to the shared drive.
  • Members to review the shared documents and provide feedback.
  • TF2-#497 Irena, Karl to continue working on collecting data from Google and other providers.

Action items from Maintainers, Jul 22 call:

  • Maintainers-#497: Karl to finalize the supporting documentation for SKU details.
    Aim to reach TF consensus by August 12.

Action items from TF-2 call on July 24:

  • Review and Refine SKU Price Details:
    Team members were tasked with reviewing the list of properties included in SKU price details. This includes determining what should be included and ensuring that the attributes are accurately defined and relevant to pricing data.
  • Provide Examples and Mock Data:
    The team was instructed to provide more examples and mock data, using real-world scenarios where possible, to help illustrate the intended structure and content of SKU price details. This includes utilizing sanitized data samples for clarity.
  • Create Guidelines for Including Data:
    Develop guidelines for what type of information should be included in SKU price details versus SKU details. This involves distinguishing between properties that should be classified under each category and establishing criteria for consistency across different cloud providers.

Action Items from TF-2 call on July 31st:

  • TF2-#497 Karl to clarify the phrasing regarding the inclusion of properties in SKU details and SKU price details, allowing for flexibility based on provider decisions.
  • TF2-#497 A summary of the discussions, open issues, and decisions will be added to the supporting content of the pull request.

Action Items from the Maintainer's call on August 5th:

  • [TF1-#497-#503] Karl is waiting for group’s feedback. If someone disagrees with the current proposal, they should present a competing alternative.

@jpradocueva jpradocueva mentioned this issue Aug 6, 2024
Merged
@jpradocueva jpradocueva linked a pull request Aug 26, 2024 that will close this issue
#503a - Update SkuPriceId per SkuPriceDetails #530
Merged
@github-project-automation github-project-automation bot moved this from R&A to Closed in FOCUS WG Sep 5, 2024
jpradocueva added a commit that referenced this issue Sep 5, 2024
@kk09v @jpradocueva
@flanakin @udam-f2 @ijurica
FOCUS #497: SkuPriceDetails column (#503)
31803cb 
Introduction of _KeyValueFormat_ columns _SkuDetails_ and
_SkuPriceDetails_ to capture properties of a **SKU ID** and **SKU Price
ID**, respectively.

**Lead Maintainer**: Karl
### Documents: 
*
[#497](#497)
SKU Price Details (Issue)
* Folder:
[#497-srv-SKU-details-SKU-price-details](https://drive.google.com/drive/folders/1kbNNasX0xZBbLrcs1MQK5s5zWyv9o8CD?usp=drive_link)
* PR
[#503](#503)
SKU Details + SKU PriceDetails Columns by
[[email protected]](mailto:[email protected])
* PR
[#530](#530)
#503a - Update SkuPriceId per SkuPriceDetails by
[[email protected]](mailto:[email protected])
* Spreadsheet:[
24.07.17-AzureEA-FOCUS-and-PriceList-sample-dataset](https://docs.google.com/spreadsheets/d/1qoy5OjFeZFIK5fuVUKGiI_yCfN5_9tBxVBaRVlBgXtA/edit?gid=240278343#gid=240278343)
* Document from Joseph:[ SKU Details from
Providers](https://docs.google.com/document/d/1zPEUZ5L5wf9YAJ63ymW3tyrOFx-krJBB6sf1bHU_oOs/edit#heading=h.p2oplf92wckb)

---------

Co-authored-by: Joaquin <[email protected]>
Co-authored-by: Michael Flanakin <[email protected]>
Co-authored-by: Joaquin <[email protected]>
Co-authored-by: Udam Dewaraja <[email protected]>
Co-authored-by: Irena Jurica <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnalpay shawnalpay

@aqu-erp aqu-erp

@kk09v kk09v

Labels
discussion topic Item or question to be discussed by the community sku details Attributes related to the SKU entity
Projects
FOCUS WG
Status: Closed
Milestone
v1.1
4 participants
@jpradocueva @shawnalpay @aqu-erp @kk09v