This repository has been archived by the owner on Aug 25, 2018. It is now read-only.
Rebuild: parallelize dependencies downloads #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did some more testing of speed - results below
Note: there was 53 dependencies. |
Closed
|
ping @FiloSottile - i was wondering what's your opinion about this PR? |
|
Thanks @petrkotek! Looks good |
FiloSottile
added a commit
that referenced
this pull request
Dec 5, 2015
Rebuild: parallelize dependencies downloads
|
Thank you, @FiloSottile 🙇 |
FiloSottile
added a commit
to FiloSottile/gb
that referenced
this pull request
Jan 18, 2016
FiloSottile
added a commit
to FiloSottile/gb
that referenced
this pull request
Jan 18, 2016
FiloSottile
added a commit
to FiloSottile/gb
that referenced
this pull request
Jan 18, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes download of dependencies parallel when using
gvt rebuild(i.e. addresses #7) and significantly improves speed of the rebuild.By default, 8 connections are used, however it's possible to override it using:
gvt rebuild --connections X.This significantly improved speed of our travis builds (
gvt rebuildwas originally taking115s, now it's21swith 8 parallel download connections, i.e. more than 5x faster).Use
?w=1to review.Please let me know, what do you think about it. Thanks!