Created a Notification and Messaging Client Backend(connects to server) #164

Zedonboy · 2021-01-20T21:07:53Z

What this PR does:
Created The necessary backend part of realtime notification and messaging.

Which issue(s) this PR fixes:

It adds Feature for Realtime Notification and Messaging

Special notes for reviewers:

Devs can create frontends that connects to this library and Make UI changes.:

todo · 2021-01-20T21:07:55Z

("fill up the Object properties")

FightPandemics-android/socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/wsTypes.kt

Lines 5 to 10 in 685f0b8

    
           //TODO("fill up the Object properties") 
        
           data class Message(val content : String? = null, val authorId : String? = null){ 
        
               val _id : String? = null 
        
           } 
        
           data class wsCallBack<T>(val onSuccess : (data : T) -> Unit, val onError : (Error?) -> Unit)

This comment was generated by todo based on a `TODO` comment in `685f0b8` in #164. cc @FightPandemics.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

ktlint

github-actions · 2021-01-20T21:08:42Z

...nagerLib/src/androidTest/java/com/fightpandemics/socketmanagerlib/ExampleInstrumentedTest.kt

@@ -0,0 +1,24 @@
+package com.fightpandemics.socketmanagerlib


🚫 [ktlint] _{reported by reviewdog 🐶}
File must end with a newline (\n)

github-actions · 2021-01-20T21:08:42Z

...nagerLib/src/androidTest/java/com/fightpandemics/socketmanagerlib/ExampleInstrumentedTest.kt

@@ -0,0 +1,24 @@
+package com.fightpandemics.socketmanagerlib
+
+import androidx.test.platform.app.InstrumentationRegistry


🚫 [ktlint] _{reported by reviewdog 🐶}
Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end

github-actions · 2021-01-20T21:08:42Z

...nagerLib/src/androidTest/java/com/fightpandemics/socketmanagerlib/ExampleInstrumentedTest.kt

+import org.junit.Test
+import org.junit.runner.RunWith
+
+import org.junit.Assert.*


🚫 [ktlint] _{reported by reviewdog 🐶}
Wildcard import (cannot be auto-corrected)

github-actions · 2021-01-20T21:08:42Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

@@ -0,0 +1,399 @@
+package com.fightpandemics.socketmanagerlib


🚫 [ktlint] _{reported by reviewdog 🐶}
File must end with a newline (\n)

github-actions · 2021-01-20T21:08:42Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+ * 3. Make sure forceRoomUpdate is implemented or assigned a lambda.
+ * */
+class SocketComponentBackend {
+    private var _socket : Socket


🚫 [ktlint] _{reported by reviewdog 🐶}
Unexpected spacing before ":"

github-actions · 2021-01-20T21:08:44Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+    fun identify(organisationId : String, oldRoomId : String, cb : wsCallBack<Boolean>) {
+        val jsonObject = JSONObject()
+        jsonObject.put("organisationId", organisationId)
+        _socket.emit(IDENTIFY, jsonObject, Ack{


🚫 [ktlint] _{reported by reviewdog 🐶}
Missing newline after ","

github-actions · 2021-01-20T21:08:44Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+    fun identify(organisationId : String, oldRoomId : String, cb : wsCallBack<Boolean>) {
+        val jsonObject = JSONObject()
+        jsonObject.put("organisationId", organisationId)
+        _socket.emit(IDENTIFY, jsonObject, Ack{


🚫 [ktlint] _{reported by reviewdog 🐶}
Missing spacing before "{"

github-actions · 2021-01-20T21:08:44Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+        val jsonObject = JSONObject()
+        jsonObject.put("organisationId", organisationId)
+        _socket.emit(IDENTIFY, jsonObject, Ack{
+            if(it.isEmpty()) return@Ack


🚫 [ktlint] _{reported by reviewdog 🐶}
Missing spacing after "if"

github-actions · 2021-01-20T21:08:44Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+            val responseJSONObject = it[0] as JSONObject
+            val jsondata = responseJSONObject.toString()
+            val response = _gson.fromJson(jsondata, Response::class.java)
+            if(response.code == 200){


🚫 [ktlint] _{reported by reviewdog 🐶}
Missing spacing after "if"

github-actions · 2021-01-20T21:08:45Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+            val responseJSONObject = it[0] as JSONObject
+            val jsondata = responseJSONObject.toString()
+            val response = _gson.fromJson(jsondata, Response::class.java)
+            if(response.code == 200){


🚫 [ktlint] _{reported by reviewdog 🐶}
Missing spacing before "{"

todo · 2021-01-21T22:38:34Z

("fill up the Object properties from Backend Models")

FightPandemics-android/socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/wsTypes.kt

Lines 5 to 10 in 32de74b

    
           //TODO("fill up the Object properties from Backend Models") 
        
           data class Message(val content : String? = null, val authorId : String? = null){ 
        
               val _id : String? = null 
        
           } 
        
           data class wsCallBack<T>(val onSuccess : (data : T) -> Unit, val onError : (Error?) -> Unit)

This comment was generated by todo based on a `TODO` comment in `32de74b` in #164. cc @FightPandemics.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

ktlint

github-actions · 2021-01-21T22:39:19Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+     * This property is a function that is in charge of a situation if a user is blocked
+     * */
+    var forceRoomUpdate = fun(_: String){
+        throw UninitializedPropertyAccessException("You must implement a forceUpdateListener. " +


🚫 [ktlint] _{reported by reviewdog 🐶}
Missing newline after "("

github-actions · 2021-01-21T22:39:20Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+                _eventBus.post(WSEvent(wsEventsTypes.IDENTIFY_ERROR))
+                cb.onError(Error(response.message))
+            }
+        })


🚫 [ktlint] _{reported by reviewdog 🐶}
Missing newline before ")"

github-actions · 2021-01-21T22:39:20Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+     *
+     * */
+
+    fun sendMessage(messageData : Message, callBack: wsCallBack<Boolean>) {


🚫 [ktlint] _{reported by reviewdog 🐶}
Unexpected spacing before ":"

github-actions · 2021-01-21T22:39:20Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+
+    fun sendMessage(messageData : Message, callBack: wsCallBack<Boolean>) {
+        val jsonedMssg = _gson.toJson(messageData)
+        _socket.emit(SEND_MESSAGE, JSONObject(jsonedMssg), Ack{


🚫 [ktlint] _{reported by reviewdog 🐶}
Missing newline after "("

github-actions · 2021-01-21T22:39:20Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+
+    fun sendMessage(messageData : Message, callBack: wsCallBack<Boolean>) {
+        val jsonedMssg = _gson.toJson(messageData)
+        _socket.emit(SEND_MESSAGE, JSONObject(jsonedMssg), Ack{


🚫 [ktlint] _{reported by reviewdog 🐶}
Missing newline after ","

github-actions · 2021-01-21T22:39:22Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+     * passes a payload of JsonElement type from Gson library and null respectively
+     * */
+    fun getUserRooms(cb : wsCallBack<JsonElement?>? = null){
+        _socket.emit(GET_USER_THREADS, null, Ack{


🚫 [ktlint] _{reported by reviewdog 🐶}
Missing newline after ","

github-actions · 2021-01-21T22:39:22Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+     * passes a payload of JsonElement type from Gson library and null respectively
+     * */
+    fun getUserRooms(cb : wsCallBack<JsonElement?>? = null){
+        _socket.emit(GET_USER_THREADS, null, Ack{


🚫 [ktlint] _{reported by reviewdog 🐶}
Missing spacing before "{"

github-actions · 2021-01-21T22:39:22Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+            if (it.isEmpty()) return@Ack // I hate nonsense!!
+            val jsonobj = it[0] as JSONObject
+            val response = _gson.fromJson(jsonobj.toString(), Response::class.java)
+            if(response.code == 200){


🚫 [ktlint] _{reported by reviewdog 🐶}
Missing spacing after "if"

github-actions · 2021-01-21T22:39:22Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+            if (it.isEmpty()) return@Ack // I hate nonsense!!
+            val jsonobj = it[0] as JSONObject
+            val response = _gson.fromJson(jsonobj.toString(), Response::class.java)
+            if(response.code == 200){


🚫 [ktlint] _{reported by reviewdog 🐶}
Missing spacing before "{"

github-actions · 2021-01-21T22:39:22Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+                _eventBus.post(WSEvent(wsEventsTypes.GET_ROOMS_ERROR))
+                cb?.onError?.invoke(Error(response.message))
+            }
+        })


🚫 [ktlint] _{reported by reviewdog 🐶}
Missing newline before ")"

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

ktlint

github-actions · 2021-01-21T22:52:34Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+     * This Function posts GET_MESSAGE_HISTORY and GET_MESSAGE_HISTORY_ERROR Events,
+     * passes a payload of JsonElement type from Gson library and null respectively
+     * */
+    fun getChatLog(data : GetChatLog, cb: wsCallBack<JsonElement?>? = null) {


🚫 [ktlint] _{reported by reviewdog 🐶}
Unexpected spacing before ":"

github-actions · 2021-01-21T22:52:34Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+     * */
+    fun getChatLog(data : GetChatLog, cb: wsCallBack<JsonElement?>? = null) {
+        val jsonedMssg = _gson.toJson(data)
+        _socket.emit(GET_CHAT_LOG, JSONObject(jsonedMssg), Ack {


🚫 [ktlint] _{reported by reviewdog 🐶}
Missing newline after "("

github-actions · 2021-01-21T22:52:34Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+     * */
+    fun getChatLog(data : GetChatLog, cb: wsCallBack<JsonElement?>? = null) {
+        val jsonedMssg = _gson.toJson(data)
+        _socket.emit(GET_CHAT_LOG, JSONObject(jsonedMssg), Ack {


🚫 [ktlint] _{reported by reviewdog 🐶}
Missing newline after ","

github-actions · 2021-01-21T22:52:34Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+            if (it.isEmpty()) return@Ack // I hate nonsense!!
+            val jsonobj = it[0] as JSONObject
+            val response = _gson.fromJson(jsonobj.toString(), Response::class.java)
+            if(response.code == 200){


🚫 [ktlint] _{reported by reviewdog 🐶}
Missing spacing after "if"

github-actions · 2021-01-21T22:52:34Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+            if (it.isEmpty()) return@Ack // I hate nonsense!!
+            val jsonobj = it[0] as JSONObject
+            val response = _gson.fromJson(jsonobj.toString(), Response::class.java)
+            if(response.code == 200){


🚫 [ktlint] _{reported by reviewdog 🐶}
Missing spacing before "{"

github-actions · 2021-01-21T22:52:37Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+            if (it.isEmpty()) return@Ack // I hate nonsense!!
+            val jsonobj = it[0] as JSONObject
+            val response = _gson.fromJson(jsonobj.toString(), Response::class.java)
+            if(response.code == 200){


🚫 [ktlint] _{reported by reviewdog 🐶}
Missing spacing after "if"

github-actions · 2021-01-21T22:52:37Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+            if (it.isEmpty()) return@Ack // I hate nonsense!!
+            val jsonobj = it[0] as JSONObject
+            val response = _gson.fromJson(jsonobj.toString(), Response::class.java)
+            if(response.code == 200){


🚫 [ktlint] _{reported by reviewdog 🐶}
Missing spacing before "{"

github-actions · 2021-01-21T22:52:37Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+            if(response.code == 200){
+                joinRoom(JoinRoom(threadId), cb)
+            } else cb?.onError?.invoke(Error(response.message))
+        })


🚫 [ktlint] _{reported by reviewdog 🐶}
Missing newline before ")"

github-actions · 2021-01-21T22:52:37Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+        })
+    }
+
+    fun archiveThread(threadId : String, cb: wsCallBack<JsonElement?>? = null) {


🚫 [ktlint] _{reported by reviewdog 🐶}
Unexpected spacing before ":"

github-actions · 2021-01-21T22:52:37Z

socketManagerLib/src/main/java/com/fightpandemics/socketmanagerlib/SocketComponent.kt

+        val jsondata = JSONObject()
+        jsondata.put("threadId", threadId)
+        jsondata.put("newStatus", "archived")
+        _socket.emit(UPDATE_THREAD_STATUS, jsondata, Ack {


🚫 [ktlint] _{reported by reviewdog 🐶}
Missing newline after "("

carl05

Please try to solve ktlints issues reported by reviewdog. You can add a plgin to android studio and it automatically show these errors and sugguests quick actions to solve it.

Created a Notification and Messaging Client Backend(connects to server)

685f0b8

github-actions bot reviewed Jan 20, 2021

View reviewed changes

Changed Generic Exception to Concrete Exception

32de74b

github-actions bot reviewed Jan 21, 2021

View reviewed changes

Zedonboy closed this Jan 21, 2021

Zedonboy reopened this Jan 21, 2021

github-actions bot reviewed Jan 21, 2021

View reviewed changes

carl05 assigned carl05 and jaliquiel Jan 27, 2021

carl05 requested changes Jan 27, 2021

View reviewed changes

		@@ -0,0 +1,24 @@
		package com.fightpandemics.socketmanagerlib

		import androidx.test.platform.app.InstrumentationRegistry

		@@ -0,0 +1,399 @@
		package com.fightpandemics.socketmanagerlib

Created a Notification and Messaging Client Backend(connects to server) #164

Are you sure you want to change the base?

Created a Notification and Messaging Client Backend(connects to server) #164

Conversation

Zedonboy commented Jan 20, 2021

todo bot commented Jan 20, 2021

("fill up the Object properties")

This comment was generated by todo based on a TODO comment in 685f0b8 in #164. cc @FightPandemics.

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jan 20, 2021

Choose a reason for hiding this comment

github-actions bot Jan 20, 2021

Choose a reason for hiding this comment

github-actions bot Jan 20, 2021

Choose a reason for hiding this comment

github-actions bot Jan 20, 2021

Choose a reason for hiding this comment

github-actions bot Jan 20, 2021

Choose a reason for hiding this comment

github-actions bot Jan 20, 2021

Choose a reason for hiding this comment

github-actions bot Jan 20, 2021

Choose a reason for hiding this comment

github-actions bot Jan 20, 2021

Choose a reason for hiding this comment

github-actions bot Jan 20, 2021

Choose a reason for hiding this comment

github-actions bot Jan 20, 2021

Choose a reason for hiding this comment

todo bot commented Jan 21, 2021

("fill up the Object properties from Backend Models")

This comment was generated by todo based on a TODO comment in 32de74b in #164. cc @FightPandemics.

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jan 21, 2021

Choose a reason for hiding this comment

github-actions bot Jan 21, 2021

Choose a reason for hiding this comment

github-actions bot Jan 21, 2021

Choose a reason for hiding this comment

github-actions bot Jan 21, 2021

Choose a reason for hiding this comment

github-actions bot Jan 21, 2021

Choose a reason for hiding this comment

github-actions bot Jan 21, 2021

Choose a reason for hiding this comment

github-actions bot Jan 21, 2021

Choose a reason for hiding this comment

github-actions bot Jan 21, 2021

Choose a reason for hiding this comment

github-actions bot Jan 21, 2021

Choose a reason for hiding this comment

github-actions bot Jan 21, 2021

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jan 21, 2021

Choose a reason for hiding this comment

github-actions bot Jan 21, 2021

Choose a reason for hiding this comment

github-actions bot Jan 21, 2021

Choose a reason for hiding this comment

github-actions bot Jan 21, 2021

Choose a reason for hiding this comment

github-actions bot Jan 21, 2021

Choose a reason for hiding this comment

github-actions bot Jan 21, 2021

Choose a reason for hiding this comment

github-actions bot Jan 21, 2021

Choose a reason for hiding this comment

github-actions bot Jan 21, 2021

Choose a reason for hiding this comment

github-actions bot Jan 21, 2021

Choose a reason for hiding this comment

github-actions bot Jan 21, 2021

Choose a reason for hiding this comment

carl05 left a comment

Choose a reason for hiding this comment

This comment was generated by todo based on a `TODO` comment in `685f0b8` in #164. cc @FightPandemics.

This comment was generated by todo based on a `TODO` comment in `32de74b` in #164. cc @FightPandemics.