Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: New vector interpolations and mappings #798

Draft
wants to merge 173 commits into
base: master
Choose a base branch
from

Conversation

KnutAM
Copy link
Member

@KnutAM KnutAM commented Sep 23, 2023

Implements Hcurl (Nedelec) and Hdiv (RaviartThomas and BrezziDouglasMarini) interpolations and the associated mappings.

To ensure that the infrastructure works well, I would aim to have the following here

  • Tests for H(div) and H(curl) on reference element
  • Continuity testing for mapped H(div) and H(curl)
  • Test homogeneous Dirichlet BC for all interpolations
  • Tutorial with H(div) elements: preview
  • Tutorial with H(curl) elements preview
  • Test reinit without gradients

Possible tutorials/validations

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2023

Codecov Report

Attention: Patch coverage is 66.50943% with 71 lines in your changes missing coverage. Please review.

Project coverage is 89.79%. Comparing base (5153307) to head (ac0d5ad).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/interpolations.jl 75.00% 33 Missing ⚠️
src/FEValues/BoundaryValues.jl 0.00% 21 Missing ⚠️
src/FEValues/FunctionValues.jl 65.30% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #798      +/-   ##
==========================================
- Coverage   93.57%   89.79%   -3.79%     
==========================================
  Files          39       40       +1     
  Lines        6071     6416     +345     
==========================================
+ Hits         5681     5761      +80     
- Misses        390      655     +265     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/src/devdocs/mapping.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for H(curl) and H(div) elements
5 participants