-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce getgrid(dh::AbstractDofHandler) function #552
Conversation
I am at least a sucker for field access, and disliker of |
Note: This is related to #486 . I propagated getgrid there through most of the code as a compatibility layer against non-distributed assembly. |
Ah, great 👍 - I missed that you had already done that there! |
No problem. I have to admit that the PR is really hard to read, which is why I am trying to break the PR into several smaller ones, fixing one open issue after another. Two major things which I want to consider first is
However, since I am currently not having time to address these issues properly, I am fine if you cherry pick some changes, polish them, and merge them. |
Codecov ReportBase: 92.76% // Head: 92.81% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #552 +/- ##
==========================================
+ Coverage 92.76% 92.81% +0.04%
==========================================
Files 28 24 -4
Lines 4203 3979 -224
==========================================
- Hits 3899 3693 -206
+ Misses 304 286 -18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Closing as handled in #486 |
I find myself quite often using
dh.grid
, and that is also the case in Ferrite's source code.While this is fine for both
DofHandler
andMixedDofHandler
, it feels "dangerous" forAbstractDofHandler
, and I think it would be nice to have an access function here.If you think this is a good idea, like [and subscribe]:)
Then I will go through the rest of the source code and update it.
For now, only DofHandler.jl is updated as a demo