use StableRNGs for testing the sha of the exported files #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
reviewed
Jun 4, 2021
| Random.seed!(1234) | ||
| u = rand(ndofs(dofhandler)) | ||
| rng = StableRNG(1234) | ||
| u = rand(rng, ndofs(dofhandler)) |
There was a problem hiding this comment.
If this is the only place rng is used perhaps just collect(1:ndofs(dofhandler))?
|
This will fix #351 |
kimauth
added a commit
to kimauth/JuAFEM.jl
that referenced
this pull request
Jul 29, 2021
…outside of vtk export (#10) * use StableRNGs for testing the sha of the exported files (Ferrite-FEM#350) * refactor vtk_point_data(vtkfile, dh, u) * remove unnecessary import Co-authored-by: Kristoffer Carlsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents tests from error when Julia's RNG change.