Add support for adding constraints to nodes when using MixedDofHandler #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With mixed meshes it does not make sense to have a default_interpolation(ch.dh.grid) defined.
Update with recent PRs
This was referenced Mar 31, 2021
|
Replaced by #346 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an additional _add! function that allows to add Dirichlet BCs to nodesets for the MixedDofHandler. I turned out to need this, so maybe somebody else also appreciates it. :)
A few comments:
I bypass _check_cellset_dirichlet: Having to filter a nodeset by which nodes belong to the cellset of the FieldHandler beforehand doesn't seem reasonable to me, considering that the new _add! just skips all nodes that either don't belong to the FieldHandler or don't have dofs in the constrained field.
Probably it would be possible to use the same _add! for the regular DofHandler and the MixedDofHandler, by just handing it a cellset of 1:getncells(ch.dh.grid) by default (but I was afraid to break something...).
I think checking for a default_interpolation(getcelltype(ch.dh.grid)) doesn't make much sense for a mixed grid. Though I don't really understand whats the problem about adding node constraints to sub/superparametric approximations, so if I could get an explanation about that, I am happy to come up with a check that makes more sense for mixed grids.