Add possibility to add bcs on edges/vertices #291

lijas · 2020-05-17T14:24:06Z

Useful for for example "simply supported" bcs.
Also useful for shell elements which only has edges.

See Cantilever.ipynb for example usage

codecov-io · 2020-05-17T14:49:11Z

Codecov Report

Merging #291 into master will decrease coverage by 0.56%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
- Coverage   85.97%   85.40%   -0.57%     
==========================================
  Files          21       21              
  Lines        1961     2001      +40     
==========================================
+ Hits         1686     1709      +23     
- Misses        275      292      +17

Impacted Files	Coverage Δ
src/interpolations.jl	`89.80% <0.00%> (-1.75%)`	⬇️
src/Dofs/MixedDofHandler.jl	`75.24% <8.33%> (-3.22%)`	⬇️
src/Grid/grid.jl	`82.39% <79.31%> (-1.35%)`	⬇️
src/Dofs/ConstraintHandler.jl	`90.29% <100.00%> (+0.49%)`	⬆️
src/Dofs/DofHandler.jl	`83.33% <100.00%> (-0.42%)`	⬇️
src/FEValues/face_values.jl	`100.00% <100.00%> (ø)`
src/Grid/grid_generators.jl	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20d14ac...ef6504d. Read the comment docs.

KristofferC · 2020-05-23T09:47:47Z

src/Dofs/ConstraintHandler.jl

@@ -145,7 +157,7 @@ function _add!(ch::ConstraintHandler, dbc::Dirichlet, bcfaces::Set{Tuple{Int,Int
    # loop over all the faces in the set and add the global dofs to `constrained_dofs`
    constrained_dofs = Int[]
    #_celldofs = fill(0, ndofs_per_cell(ch.dh))
-    for (cellidx, faceidx) in bcfaces
+    for  (cellidx, faceidx) in bcfaces


Suggested change

for (cellidx, faceidx) in bcfaces

for (cellidx, faceidx) in bcfaces

KristofferC · 2020-05-23T09:53:07Z

docs/src/literate/incompressible_elasticity.jl

@@ -157,7 +157,7 @@ function assemble_up!(Ke, fe, cell, cellvalues_u, cellvalues_p, facevalues_u, gr
    ## We loop over all the faces in the cell, then check if the face
    ## is in our `"traction"` faceset.
    @inbounds for face in 1:nfaces(cell)
-        if onboundary(cell, face) && (cellid(cell), face) ∈ getfaceset(grid, "traction")
+        if onboundary(cell, face) && FaceIndex(cellid(cell), face) ∈ getfaceset(grid, "traction")


Hm, I guess this is pretty breaking. Perhaps we can leave FaceIndex as const FaceIndex = Tuple{Int, Int} but use struct for the others?

KristofferC · 2020-05-23T09:54:18Z

examples/cantilever.ipynb

-     "output_type": "stream",
-     "text": [
-      " \u001b[1m------------------------------------------------------------------\u001b[22m\n",
-      "                           Time                   Allocations      \n",


Did this table go away?

KristofferC · 2020-05-23T09:54:50Z

src/Dofs/ConstraintHandler.jl

@@ -229,6 +241,7 @@ function _update!(values::Vector{Float64}, f::Function, faces::Set{Tuple{Int,Int
    _celldofs = fill(0, ndofs_per_cell(dh, _tmp_cellid))

    for (cellidx, faceidx) in faces
+


Suggested change

KristofferC · 2020-05-23T09:54:58Z

src/Dofs/ConstraintHandler.jl

@@ -395,22 +409,30 @@ end

 #Function for adding constraint when using multiple celltypes
 function add!(ch::ConstraintHandler, fh::FieldHandler, dbc::Dirichlet)
-    dbc.faces isa Set{Tuple{Int}} && error("Can only apply boundary conditions to faces (not nodes).")
+


Suggested change

codecov-commenter · 2020-05-25T19:50:19Z

Codecov Report

Merging #291 into master will decrease coverage by 0.46%.
The diff coverage is 83.63%.

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
- Coverage   85.97%   85.51%   -0.47%     
==========================================
  Files          21       21              
  Lines        1961     2002      +41     
==========================================
+ Hits         1686     1712      +26     
- Misses        275      290      +15

Impacted Files	Coverage Δ
src/Dofs/MixedDofHandler.jl	`75.24% <8.33%> (-3.22%)`	⬇️
src/interpolations.jl	`90.44% <33.33%> (-1.12%)`	⬇️
src/Grid/grid.jl	`83.21% <83.33%> (-0.53%)`	⬇️
src/Dofs/ConstraintHandler.jl	`90.29% <100.00%> (+0.49%)`	⬆️
src/Dofs/DofHandler.jl	`83.33% <100.00%> (-0.42%)`	⬇️
src/FEValues/face_values.jl	`100.00% <100.00%> (ø)`
src/Grid/grid_generators.jl	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20d14ac...e749c82. Read the comment docs.

lijas · 2021-02-28T17:48:30Z

I added a simple example with shell elements, which is the strongest motivation why one needs to be able to add BCs on edges/vertices. I am planning to write some text for the example so that it can be added to the other tutorials.

I would also like some feedback on the structure of the code. Currently in the add!-function for the ConstraintHandler, I changed it so that it creates BCValues for either faces, edges or vertices:

function add!(ch::ConstraintHandler, dbc::Dirichlet)
...
functype = getgeometryfunction(eltype(dbc.bcset)) # eltype(dbc.bcset) is either FaceIndex, EdgeIndex or VertexIndes
bcvalue = BCValues(interpolation, JuAFEM.default_interpolation(celltype), functype)
_add!(ch, dbc, dbc.bcset, interpolation, field_dim, field_offset(ch.dh, dbc.field_name), bcvalue, functype)

where

getgeometryfunction(::Type{FaceIndex}) = JuAFEM.faces
getgeometryfunction(::Type{EdgeIndex}) = JuAFEM.edges
getgeometryfunction(::Type{VertexIndex}) = JuAFEM.vertices

Do you think it is clear what getgeometryfunction is doing? Is there a better name? Or should we skip it all together and just do

if eltype(dbc.bcset) isa FaceIndex
    functype = JuAFEM.faces
elseif eltype(dbc.bcset) isa EdgeIndex
   functype = JuAFEM.edges
elseif eltype(dbc.bcset) isa VertexIndex
   functype = JuAFEM.vertices
end
bcvalue = BCValues(interpolation, JuAFEM.default_interpolation(celltype), functype)
_add!(ch, dbc, dbc.faces, interpolation, field_dim, field_offset(ch.dh, dbc.field_name), bcvalue, functype)

Any feedback would be appriciated..

KristofferC · 2021-03-02T13:59:06Z

I think doing the explicit if makes sense for now. If the same type of code occurs in other places, it could be changed out to dispatch.

Add image add todo to dofhandler move code to BcValue constructor

add docs for BCValues change JuAFEM -> Ferrite in some places

lijas · 2021-03-31T07:40:04Z

Close due to #343

KristofferC reviewed May 23, 2020

View reviewed changes

lijas mentioned this pull request Oct 12, 2020

Make it possible to distribute dofs for shells and beams/bars in 2d/3d #296

Merged

lijas force-pushed the bcs2 branch from e749c82 to 9b90693 Compare February 21, 2021 18:28

lijas and others added 13 commits March 30, 2021 15:53

wip bc

7e75b63

more work

dbdf015

cleanup

6bead07

cleanup2

13a892e

add edge function to interpolations and update cantilever.ipynb

2d17424

fix wrt comments

6771c97

wip

302d7d3

add tests

2588b61

add vtkcells for 2d-line and shells

9caab02

update doc

8b77efb

Change tutorial a bit

40ede7e

Add image add todo to dofhandler move code to BcValue constructor

Add boundaryindex type

6a039d4

add some more test

f0cbd12

add docs for BCValues change JuAFEM -> Ferrite in some places

lijas force-pushed the bcs2 branch from 9b90693 to f0cbd12 Compare March 30, 2021 14:56

lijas closed this Mar 31, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add possibility to add bcs on edges/vertices #291

Add possibility to add bcs on edges/vertices #291

lijas commented May 17, 2020

codecov-io commented May 17, 2020 •

edited

Loading

KristofferC May 23, 2020

KristofferC May 23, 2020

KristofferC May 23, 2020

KristofferC May 23, 2020

KristofferC May 23, 2020

codecov-commenter commented May 25, 2020 •

edited

Loading

lijas commented Feb 28, 2021

KristofferC commented Mar 2, 2021

lijas commented Mar 31, 2021

	for (cellidx, faceidx) in bcfaces
	for (cellidx, faceidx) in bcfaces

		@@ -229,6 +241,7 @@ function _update!(values::Vector{Float64}, f::Function, faces::Set{Tuple{Int,Int
		_celldofs = fill(0, ndofs_per_cell(dh, _tmp_cellid))

		for (cellidx, faceidx) in faces

Add possibility to add bcs on edges/vertices #291

Add possibility to add bcs on edges/vertices #291

Conversation

lijas commented May 17, 2020

codecov-io commented May 17, 2020 • edited Loading

Codecov Report

KristofferC May 23, 2020

Choose a reason for hiding this comment

KristofferC May 23, 2020

Choose a reason for hiding this comment

KristofferC May 23, 2020

Choose a reason for hiding this comment

KristofferC May 23, 2020

Choose a reason for hiding this comment

KristofferC May 23, 2020

Choose a reason for hiding this comment

codecov-commenter commented May 25, 2020 • edited Loading

Codecov Report

lijas commented Feb 28, 2021

KristofferC commented Mar 2, 2021

lijas commented Mar 31, 2021

codecov-io commented May 17, 2020 •

edited

Loading

codecov-commenter commented May 25, 2020 •

edited

Loading