Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store boundaries in a matrix #130

Merged
merged 2 commits into from
Apr 4, 2017
Merged

store boundaries in a matrix #130

merged 2 commits into from
Apr 4, 2017

Conversation

KristofferC
Copy link
Collaborator

No description provided.

@KristofferC KristofferC requested a review from fredrikekre April 4, 2017 12:57
src/Grid/grid.jl Outdated
nfaces{dim, N, M}(::Type{Cell{dim, N, M}}) = M

# Typealias for commonly used cells
nfaces{dim, N, M}(::Type{Cell{dim, N, M}}) = M# Typealias for commonly used cells
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment should be on line below

@codecov-io
Copy link

Codecov Report

Merging #130 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
- Coverage   87.91%   87.86%   -0.05%     
==========================================
  Files          17       17              
  Lines        1274     1269       -5     
==========================================
- Hits         1120     1115       -5     
  Misses        154      154
Impacted Files Coverage Δ
src/iterators.jl 65.62% <100%> (ø) ⬆️
src/Grid/grid_generators.jl 98.91% <100%> (-0.02%) ⬇️
src/Grid/grid.jl 34.78% <100%> (-2.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48e39a0...d842a61. Read the comment docs.

@KristofferC KristofferC merged commit 31d38b1 into master Apr 4, 2017
@fredrikekre fredrikekre deleted the kc/boundary_matrix branch April 4, 2017 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants