-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Julia v0.6 fix #123
Merged
Merged
Julia v0.6 fix #123
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a49f7b4
WIP julia v0.6 fix
fredrikekre e586df2
enable testing on nightly
fredrikekre dbc24ce
even this segfaults but only when this file in included...
fredrikekre 3a1d66e
restore tests
fredrikekre b110e36
temporarily skip some tests on 0.6
fredrikekre 7763a7b
fix doctets
fredrikekre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ os: | |
|
||
julia: | ||
- 0.5 | ||
# - nightly | ||
- nightly | ||
|
||
notifications: | ||
email: false | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,3 +4,4 @@ Requires | |
WriteVTK 0.4.0 | ||
Reexport | ||
Tensors | ||
Compat 0.19.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
using SHA | ||
@testset "VTK" begin | ||
if VERSION.minor < 6 # temporarily skip tests on this until | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Skipping 0.6 tests here. Seems to work outside the test suite so thats nice at least. julia> function foo()
grid = generate_grid(Triangle, (2, 2))
vtk = vtk_grid("testfile", grid)
vtk_save(vtk)
end
foo (generic function with 1 method)
julia> foo()
1-element Array{String,1}:
"testfile.vtu" |
||
# JuliaLang/julia#17003 is fixed | ||
OVERWRITE_CHECKSUMS = false | ||
checksums_file = joinpath(dirname(@__FILE__), "checksums.sha1") | ||
checksum_list = readstring(checksums_file) | ||
|
@@ -57,25 +59,10 @@ using SHA | |
@test cmp != 0:-1 | ||
rm(name*".vtu") | ||
end | ||
|
||
# Test deprecated method, PR #70 | ||
coordmat = reinterpret(Float64,coord,(size(coord[1],1),length(coord))) | ||
|
||
vtkfile = vtk_grid(edof, coordmat, name*"_old") | ||
vtk_save(vtkfile) | ||
|
||
sha = bytes2hex(sha1(name*"_old.vtu")) | ||
if OVERWRITE_CHECKSUMS | ||
write(csio, sha*" "*name*"_old.vtu\n") | ||
else | ||
# Returns 0:-1 if string is not found | ||
cmp = search(checksum_list, sha) | ||
@test cmp != 0:-1 | ||
rm(name*"_old.vtu") | ||
end | ||
end | ||
|
||
OVERWRITE_CHECKSUMS && close(csio) | ||
end | ||
|
||
# Test getVTKtype | ||
for interpolation in (Lagrange{1, RefCube, 1}(), | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing this since some packages still spew out deprecations...