Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend COOAssembler to also handle vector assembly #1058

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

fredrikekre
Copy link
Member

Follow up to #916.

@fredrikekre fredrikekre added this to the v1.0.0 milestone Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.71%. Comparing base (c6e65e0) to head (a6eb9ce).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/assembler.jl 87.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1058      +/-   ##
==========================================
- Coverage   93.73%   93.71%   -0.03%     
==========================================
  Files          39       39              
  Lines        6017     6042      +25     
==========================================
+ Hits         5640     5662      +22     
- Misses        377      380       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/assembler.jl Outdated Show resolved Hide resolved
@fredrikekre fredrikekre mentioned this pull request Sep 19, 2024
2 tasks
src/assembler.jl Outdated Show resolved Hide resolved
@fredrikekre
Copy link
Member Author

fredrikekre commented Sep 27, 2024

In order to make progress with 1.0 I did this:

users who wants the COOAssembler should simply call assembler = COOAssembler(args...; kwargs...)

for now and we can decide later if we are introducing a COOMatrix or something to call start_assemble on (I started on something like that in #566 but don't remember why I didn't like it).

@fredrikekre fredrikekre merged commit 0f38702 into master Sep 27, 2024
9 of 11 checks passed
@fredrikekre fredrikekre deleted the fe/coo branch September 27, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants