Alexleung/dev v070 for refactor #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s center, we split the client runner and server runner into four base classes: agent, protocol manager, job runner manager, job runner. 2. Add the unified account manager to bind into the MLOps backend. 3. Abstract the same design paradigm for launching and deployment scheduler with the following format: agent -> protocol manager -> job runner manager -> job runner. 4. For better debugging messages, we save the message records to local files for sender and receiver in the message center. 5. Write the class diagram and sequence diagram in the lark doc ( https://fedml-inc.larksuite.com/wiki/NpTUwdXnciBlpQkxPkBu79k0sPc, section: FEDML Launch Python(v2) )
…anch_online # Conflicts: # python/fedml/__init__.py # python/fedml/computing/scheduler/master/server_runner.py # python/fedml/computing/scheduler/model_scheduler/device_client_runner.py # python/fedml/computing/scheduler/model_scheduler/device_model_cache.py # python/fedml/computing/scheduler/model_scheduler/device_model_deployment.py # python/fedml/computing/scheduler/model_scheduler/device_model_msg_object.py # python/fedml/computing/scheduler/model_scheduler/device_replica_controller.py # python/fedml/computing/scheduler/model_scheduler/device_replica_handler.py # python/fedml/computing/scheduler/model_scheduler/device_server_runner.py # python/fedml/computing/scheduler/scheduler_core/endpoint_sync_protocol.py # python/fedml/computing/scheduler/slave/client_runner.py # python/fedml/core/mlops/__init__.py # python/setup.py
Alexleung/dev branch online
Dev/v0.7.0
Alexleung/dev branch online
…_update_name Update Launch Job Docker Image name
…id the system is blocked. 2. Fix the time error when checking the run process in the job monitor. 3. Support docker authentication when launching the job. 4. Send the edge status detecting message once in the protocol manager, save the status response message to the queue of job runner, and process the edge status in the job runner. 5. Open a process to download the package so that we can avoid the request is blocked and check the timeout. 6. Refactor the status center to make the status sequence work and stable. 7. Change the retain flag to true when establishing an MQTT connection so that we can handle messages even if the device is not started. 8. Sync the latest deployment module to this branch.
Alexleung/dev v070 for refactor
Alexleung/dev branch latest
…center name for deployments.
Alexleung/dev branch latest
[CoreEngine] make the deployment status more stable.
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9453265 | Triggered | Generic High Entropy Secret | 52b5b2d | python/fedml/workflow/driver_example/main.py | View secret |
| 9453265 | Triggered | Generic High Entropy Secret | 3417f30 | python/fedml/api/api_test.py | View secret |
| 9453265 | Triggered | Generic High Entropy Secret | c05f23a | python/fedml/api/api_test.py | View secret |
| 9453265 | Triggered | Generic High Entropy Secret | 060eef6 | python/fedml/api/api_test.py | View secret |
| 9453265 | Triggered | Generic High Entropy Secret | c607ce6 | python/fedml/api/api_test.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
fedml-alex
requested review from
fedml-dimitris,
alaydshah,
Raphael-Jin and
chaoyanghe
fedml-dimitris
suggested changes
May 14, 2024
[CoreEngine] update the keys.
fedml-dimitris
approved these changes
May 14, 2024
[CoreEngine] make the client and server runner deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the scheduler followed by the lark doc. Scheduler Arch. Test Launch/Deploy/FL,
it works.