Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deploy] Refine Autoscaling Algorithm #2041

Merged
merged 7 commits into from
Apr 26, 2024

Conversation

Raphael-Jin
Copy link
Collaborator

No description provided.

@Raphael-Jin Raphael-Jin requested a review from fedml-alex April 26, 2024 02:46
Copy link

gitguardian bot commented Apr 26, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10012969 Triggered Generic Password 0c96f95 python/fedml/computing/scheduler/model_scheduler/autoscaler/autoscaler.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@Raphael-Jin Raphael-Jin force-pushed the dimitris/autoscaler-hotfix-v2 branch from 585ba6b to e98b48e Compare April 26, 2024 02:51
@Raphael-Jin Raphael-Jin requested a review from ASCE1885 April 26, 2024 03:21
Copy link
Contributor

@ASCE1885 ASCE1885 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Raphael-Jin Raphael-Jin merged commit cdbacbf into dev/v0.7.0 Apr 26, 2024
0 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants