Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

Disables roaring imports when trackExistence is true #239

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yuce
Copy link
Contributor

@yuce yuce commented Jun 7, 2019

Fixes #238

  • Adds Field.HasRoaringImport method
  • Disables roaring imports when trackExistence is true

- Disables roaring imports when trackExistence os true
@yuce yuce changed the title Fixes #238 Disables roaring imports when trackExistence os true Jun 7, 2019
@yuce yuce changed the title Disables roaring imports when trackExistence os true Disables roaring imports when trackExistence is true Jun 7, 2019
@jaffee
Copy link
Member

jaffee commented Jun 12, 2019

Instead of making this check on the client side, I wonder if we should...
(a) disable this server side, or
(b) allow it, and also expose the ability to roaring import into the existence field. Basically, if you're using roaring imports, and existence tracking, you're responsible for updating the existence field, which in most cases can probably be done with very little overhead by importing full RLE containers in your known column range.

I'm leaning toward (b), though this probably requires a bit of work in Pilosa.

@yuce
Copy link
Contributor Author

yuce commented Jun 13, 2019

Both approaches are possible, but this PR is more like a very quick way to avoid confusion for go-pilosa users.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not roaring import if trackExistence is true
2 participants