Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(routes): add html-to-pdf route #1440

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

NHS-juju
Copy link
Contributor

Known issues: html-to-pdf plugin lacks proper input validation, so currently will render anything a browser would attempt to render and prints this to a PDF file. In turn, the testing suites for this plugin are lacking in quality compared to the overall project.

@Fdawgs Fdawgs changed the title Draft PR - HTML To PDF feat(routes): add html-to-pdf route May 4, 2023
@Fdawgs
Copy link
Owner

Fdawgs commented May 12, 2023

@NHS-juju going to take a look at this as part of /HTML/* routes alongside #1469 😄

@Fdawgs Fdawgs added this to the v10.2.0 milestone May 16, 2023
@Fdawgs Fdawgs marked this pull request as ready for review May 18, 2023 17:06
@Fdawgs
Copy link
Owner

Fdawgs commented May 18, 2023

@NHS-juju could you enable Allow edits from maintainers on this PR, please?
I'll sort all the merge conflicts and tests for this.

@NHS-juju
Copy link
Contributor Author

@Fdawgs I can't see that option, and the page you linked suggests it is because the fork is from an Organisation account and the feature is only available when the fork is owned by a personal account 😐

I attempted to resolve the conflicts via the browser, and now merging is blocked... my bad!

@Fdawgs Fdawgs modified the milestones: v10.2.0, v10.4.0 May 20, 2023
@Fdawgs Fdawgs modified the milestones: v10.4.0, v11.1.0 May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants