(#220) Switch to lookup tables in hotspots isNameChar()/isNameStartChar()
#221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…StartChar() for better performance
cowtowncoder
changed the title
isNameChar()/isNameStartChar()
|
Oh. One thing I may have forgotten to ask -- and need to do now -- if you haven't sent CLA yet (this is only needed once for any Woodstox contributions), we'd need one from: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf (same CLA used for Jackson and Woodstox, just use different project name). It is usually easiest to print, fill & sign, scan/photo, email to Once I get it we are good and I can continue merging PRs. Thanks! |
|
@cowtowncoder OK, I will clarify the contributor agreement with my company. May take some time, sorry. |
|
@winfriedgerlach That's ok -- we are not in a hurry. And fortunately it's a one-time thing. |
cowtowncoder
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note that all 7-bit ASCII chars take the shortcut via LUT now; previously, the chars 7B..7F were taking particularly many branches