Remove non-reproducible Implementation-Build-Date manifest entry
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hboutemy Do these need to be removed since they break RB? (I assume so, just checking) Do you think there is any downside? Is there equivalent metadata to indicate build time, or is that just... unavoidable loss? I don't know if tooling cares about that, and I guess artifacts still have external timestamps. |
|
I guess it's fine, how about I'll just merge this. |
cowtowncoder
changed the title
Implementation-Build-Date manifest entry
|
@hboutemy I think that Reproducible build somehow caused this: FasterXML/jackson-databind#3680 which is peculiar in that all class files do have consistent timestamp, but one that is neither one specified in Maven property NOR epoch (but 10 years later). WDYT? |
|
This sounds quite familiar: open-telemetry/opentelemetry-java-instrumentation#2517 |
|
I answered on FasterXML/jackson-databind#3680 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/com/fasterxml/jackson/annotations/jackson-annotations-2.14.0-rc1.diffoscope