Jackson 2.9.3 release for Scala module

[cowtowncoder]

2.9.3 release:

https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.9.3

going out, need Scala module too.

[mbknor]

[info] UntypedObjectDeserializerTest:
[info] UntypedObjectDeserializer
[info] - should deserialize to an immutable.Map by default
[info] - should honor AbstractTypeResolvers *** FAILED ***
[info]   Map("mData" -> "mValue") was not an instance of scala.collection.immutable.TreeMap, but an instance of scala.collection.immutable.Map$Map1 (UntypedObjectDeserializerTest.scala:52)
[info] Run completed in 498 milliseconds.
[info] Total number of tests run: 2
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 1, failed 1, canceled 0, ignored 0, pending 0
[info] *** 1 TEST FAILED ***
[error] Failed tests:
[error] 	com.fasterxml.jackson.module.scala.deser.UntypedObjectDeserializerTest
[error] (test:testOnly) sbt.TestsFailedException: Tests unsuccessful

This was not as easy as it used to be..
The upgrade to 2.9.3 broke a test, and I have not yet figured out what the problem is and how to fix it...

[cowtowncoder]

Hmmh. That is unfortunate. And none of databind fixes listed in release notes seem directly related here.
Except perhaps one of:

• Nested type arguments doesn't work with polymorphic types jackson-databind#1604
• Jackson-databind caches plain map deserializer and use it even map has @JsonDeserializer jackson-databind#1807

which could have exposed an existing issue with type compatibility.

[brharrington]

One observation, I hit this problem when running sbt on the command line or running just UntypedObjectDeserializer in the IDE. But if I run all tests in the IDE it passes. Not really sure what difference that would make.

[mbknor]

I get the same error both in sbt and in intelliJ.
Please see #359 for more info.

I guess it works in your IDE, since it has not changed from 2.9.2 to 2.9.3.

[brharrington]

I guess it works in your IDE, since it has not changed from 2.9.2 to 2.9.3.

What I'm seeing in the IDE is that:

• It works if I run all tests.
• It fails with the same error if I just run UntypedObjectDeserializerTest.

I'm guessing that there is some side effect or test ordering issue that causes it to behave differently in these cases.

[mbknor]

@brharrington thanks for that clarification! That means that the problem probably relates to caching and the order of which it is initialized.

[bestcastor]

https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.9.4

Jackson release for 2.9.4, included the fix for CVE-2017-17485.

Need Scala module to update to 2.9.4.

[cowtowncoder]

@bestcastor At this point there is no dedicated maintainer for this module, so any help you (or anyone else with skills, time & interest!) can give in figuring out how to make it happen much appreciated.

Other than that, using 2.9.2of Scala module, with rest of Jackson components at 2.9.4 is the way to go: patch releases are API compatible between each other, and CVE fixes are all in jackson-databind, none in Scala module.

[brharrington]

The difference I was seeing in the IDE was because the UntypedObjectDeserializer didn't have the @RunWith(classOf[JUnitRunner]) annotation like the other tests so it was skipped when I ran all.

[cowtowncoder]

Ok, I merged the test fix. Does this help at all with problem of failed test(s) of #359?

[mbknor]

Version 2.9.4 is now released