Skip to content

Commit

Permalink
Update minimum Java version to 17 (databind#4820) (#178)
Browse files Browse the repository at this point in the history
  • Loading branch information
cowtowncoder authored Dec 4, 2024
1 parent 638a1ff commit d51c5ec
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/dep_build_v3.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java_version: ['8', '17', '21']
java_version: ['17', '21']
env:
JAVA_OPTS: "-XX:+TieredCompilation -XX:TieredStopAtLevel=1"
steps:
Expand Down
10 changes: 4 additions & 6 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,13 @@ on:
branches:
- master
- "3.0"
- "2.19"
paths-ignore:
- "README.md"
- "release-notes/*"
pull_request:
branches:
- master
- "3.0"
- "2.19"
paths-ignore:
- "README.md"
- "release-notes/*"
Expand All @@ -25,7 +23,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java_version: ['8', '11', '17', '21']
java_version: ['17', '21']
os: ['ubuntu-22.04']
env:
JAVA_OPTS: "-XX:+TieredCompilation -XX:TieredStopAtLevel=1"
Expand All @@ -49,17 +47,17 @@ jobs:
id: projectVersion
run: echo "version=$(./mvnw org.apache.maven.plugins:maven-help-plugin:3.5.1:evaluate -DforceStdout -Dexpression=project.version -q)" >> $GITHUB_OUTPUT
- name: Deploy snapshot
if: ${{ github.event_name != 'pull_request' && matrix.java_version == '8' && endsWith(steps.projectVersion.outputs.version, '-SNAPSHOT') }}
if: ${{ github.event_name != 'pull_request' && matrix.java_version == '17' && endsWith(steps.projectVersion.outputs.version, '-SNAPSHOT') }}
env:
CI_DEPLOY_USERNAME: ${{ secrets.CI_DEPLOY_USERNAME3 }}
CI_DEPLOY_PASSWORD: ${{ secrets.CI_DEPLOY_PASSWORD3 }}
# MAVEN_GPG_PASSPHRASE: ${{ secrets.MAVEN_GPG_PASSPHRASE }}
run: ./mvnw -B -q -ff -DskipTests -ntp source:jar deploy
- name: Generate code coverage
if: ${{ github.event_name != 'pull_request' && matrix.java_version == '8' }}
if: ${{ github.event_name != 'pull_request' && matrix.java_version == '17' }}
run: ./mvnw -B -q -ff -ntp test
- name: Publish code coverage
if: ${{ github.event_name != 'pull_request' && matrix.java_version == '8' }}
if: ${{ github.event_name != 'pull_request' && matrix.java_version == '17' }}
uses: codecov/codecov-action@015f24e6818733317a2da2edd6290ab26238649a # v5.0.7
with:
token: ${{ secrets.CODECOV_TOKEN }}
Expand Down
5 changes: 5 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<!-- [databind#4820]: Java 17 baseline -->
<javac.src.version>17</javac.src.version>
<javac.target.version>17</javac.target.version>

<!-- 23-Feb-2019, tatu: Removing debug info makes jr-objects jar 20% smaller...
but loses line numbers from stack traces. So bit of a difficult choice.
-->
Expand Down
1 change: 1 addition & 0 deletions release-notes/VERSION
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@ Modules:
3.0.0 (not yet released)

#96: Rename "com.fasterxml.jackson" -> "tools.jackson"
- Minimum Java baseline: Java 17

0 comments on commit d51c5ec

Please sign in to comment.