Fix issue with BigInteger handling
#31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pjfanning
commented
Apr 8, 2023
pjfanning
commented
- I added the test case and it failed
- I debugged the code and found that org.glassfish.json.JsonNumberImpl uses BigDecimals under the hood so there is no perf benefit to trying to use doubles (and the risk with the doubles losing precision and truncating big numbers)
- what happened in my test is the Jackson code uses toDouble and that evals to Double.Infinity and things get worse from there
This was referenced Apr 8, 2023
Merged
|
SGTM/LGTM: we'd need similar for |
cowtowncoder
changed the title
cowtowncoder
changed the title
BigInteger handling
cowtowncoder
added a commit
that referenced
this pull request
Apr 9, 2023
|
@cowtowncoder could you merge #32 and #33 before the rc3 release? |
|
@pjfanning Done. I am still trying to close the loop on a few things; will sync up with you before proceeding -- won't be happening this weekend as things are (rc3 release that is) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.