Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add KeyDeserializers for LocalTime, LocalDate, & LocalDateTime #41

Merged
merged 4 commits into from
Aug 27, 2014

Conversation

bkenned4
Copy link

  • use parsers provided by ISODateFormatter to be consistent with the regular Deserializers
  • add rudimentary tests
  • switch JodaTestBase to use JodaMapper

Brad Kennedy added 4 commits May 23, 2014 22:27
- use parsers provided by ISODateFormatter to be consistent with the regular Deserializers
- add rudimentary tests
- switch JodaTestBase to use JodaMapper
- move length checking to abstract class
@guidomedina
Copy link

Any updates on this one? When is it going to be merged in? We hit this wall already for a TreeMap<LocalDate, V>, we have to use yyyyMMdd as Integer to workaround this functionality.

@cowtowncoder
Copy link
Member

@guidomedina Whoa. I somehow missed this one; sorry about that.

@bkenned4 first of all, thank you for the contribution, this looks great.
Second, one thing we unfortunately need to get before merging this in is filled-in CLA. It is just one page, and found from:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

but we need that filled in before first contribution to one of Jackson projects. After this it'll be valid for any and all contributions.
If you could scan and send signed copy to info at fasterxml.com, I will get this pull request merged in ASAP.

@bkenned4
Copy link
Author

Sent over the CLA. It was my first pull request, so I didn't know the
standard operating procedure :).

Thanks!
Brad

On Tue, Aug 26, 2014 at 10:40 PM, Tatu Saloranta [email protected]
wrote:

@guidomedina https://github.com/guidomedina Whoa. I somehow missed this
one; sorry about that.

@bkenned4 https://github.com/bkenned4 first of all, thank you for the
contribution, this looks great.
Second, one thing we unfortunately need to get before merging this in is
filled-in CLA. It is just one page, and found from:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

but we need that filled in before first contribution to one of Jackson
projects. After this it'll be valid for any and all contributions.
If you could scan and send signed copy to info at fasterxml.com, I will
get this pull request merged in ASAP.


Reply to this email directly or view it on GitHub
#41 (comment)
.

@cowtowncoder
Copy link
Member

@bkenned4 actually you did it exactly right: we'll ask for CLAs etc, different projects have different formalities so I think it's actually good to just start with a PR and we can through the rest.
Thank you again for this, it can go in 2.4.3 (and 2.5.0)

cowtowncoder added a commit that referenced this pull request Aug 27, 2014
add KeyDeserializers for LocalTime, LocalDate, & LocalDateTime
@cowtowncoder cowtowncoder merged commit bdf6c97 into FasterXML:master Aug 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants