Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit maximum TOML structure depth #395

Closed
wants to merge 1 commit into from
Closed

Limit maximum TOML structure depth #395

wants to merge 1 commit into from

Conversation

yawkat
Copy link
Member

@yawkat yawkat commented Mar 6, 2023

This replaces the StackOverflowError with a StreamReadException with a proper message.

Fixes #387

@yawkat
Limit maximum TOML structure depth
62d08fd 
This replaces the StackOverflowError with a StreamReadException with a proper message.

Fixes #387
@yawkat yawkat requested a review from cowtowncoder March 6, 2023 11:12
@pjfanning
Copy link
Member

@yawkat We've introduced a nesting depth limit on StreamReadConstraints. I borrowed your test and added it to #398

@pjfanning pjfanning mentioned this pull request Mar 7, 2023
Closed
@yawkat yawkat mentioned this pull request Mar 7, 2023
Merged
@yawkat
Copy link
Member Author

yawkat commented Mar 7, 2023

closing for now since #387 is better, we can reopen if we decide otherwise

@yawkat yawkat closed this Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowtowncoder cowtowncoder Awaiting requested review from cowtowncoder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stack overflow (50083) found by OSS-Fuzz
2 participants
@yawkat @pjfanning