CSV schema caching POJOs with different views #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- inner class CsvMapper.ViewKey as cache key
|
Thank you! |
cowtowncoder
added a commit
that referenced
this pull request
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds caching of CSV schemas for POJOs with views once they have been created (see #288).
CsvMapper.ViewKeyas cache keySchemaCaching288Testfromcom.fasterxml.jackson.dataformat.csv.schematocom.fasterxml.jackson.dataformat.csvin order to check cache usage via sizeCsvMapper.ViewKeyuses bothObjects.equals()andObjects.hashCode(). Is this acceptable or should it be changed?You would have to decide whether access modifiers for
CsvMapper.ViewKeyshould be changed and whether it would be better defined as a top-level class.