CsvMapper now honors JsonProperty index. #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting this! I will try to get this reviewed soon. |
| List<BeanPropertyDefinition> properties = beanDesc.findProperties(); | ||
|
|
||
| // soring properties by @JsonProperty index | ||
| properties.sort(comparing(o -> intr.findPropertyIndex(ctxt.getConfig(), o.getPrimaryMember()), |
There was a problem hiding this comment.
Jackson 2.x requires JDK 7, can not yet use JDK 8 features (but easy enough to change)
|
Finally got back to this. Will use provided test, but also decided that this: FasterXML/jackson-databind#2555 makes sense, to essentially try to use |
|
Turns out databind change does solve the problem, so I only had to merge test from here to verify that things now work. Thank you for contributing the test and proposed fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #115