[AVRO] Support of Avro logical type Decimal.
#542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `@Decimal` is created with logical type `decimal` and type either `bytes` (by default) or `fixed`.
…java.util.BigDecimal.
|
@MichalFoksa is this ready? If so, would need to convert from Draft to regular PR. |
|
Functionality is ready - it works. Will let you know when done. |
Sounds good, thanks! |
|
@cowtowncoder PR is ready for review. |
cowtowncoder
reviewed
Jan 4, 2025
| */ | ||
| @Target({ElementType.ANNOTATION_TYPE, ElementType.FIELD}) | ||
| @Retention(RetentionPolicy.RUNTIME) | ||
| public @interface Decimal { |
There was a problem hiding this comment.
Perhaps this should be "namespaced" as @AvroDecimal? Similar to existing @AvroNamespace.
There was a problem hiding this comment.
@Decimal renamed to @AvroDecimal.
cowtowncoder
approved these changes
Jan 4, 2025
This was referenced Jan 4, 2025
|
@MichalFoksa ah yes. I did close #132, since it does seem completed. Added two others in release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support of Avro logical type
decimal. See Logical Types - Decimal specification.@Decimalannotation instructs generator to create schema with logical type decimal in bytes Avro type. To createdecimalinfixedtype, the field has to be annotated also with@AvroFixedSize.It only works when log
Limitations:
BigDecimalfiled is annotated with@Decimal. The@Decimalannotation is ignored.BigDecimal serialization is delegated to Apache
org.apache.avro.Conversions.DecimalConversion.It validates whether value fits available schema. If not, then it throws
org.apache.avro.AvroTypeException.BigDecimal deserialization is taken from #133 . Deserialization is implemented in
AvroParserImplwhere decoding from bytes of fixed is delegated to child implementations (ApacheAvroParserImpl, respJacksonAvroParserImpl).Fixes #308 , #535.