-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Logical Type support for java.util.UUID
#536
Merged
cowtowncoder
merged 4 commits into
FasterXML:2.19
from
MichalFoksa:feature/2.19/add_logical_type_to_UUID_schema
Dec 24, 2024
Merged
Add Logical Type support for java.util.UUID
#536
cowtowncoder
merged 4 commits into
FasterXML:2.19
from
MichalFoksa:feature/2.19/add_logical_type_to_UUID_schema
Dec 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… created in Avro schema. Doc field is not mandatory and having it empty doe snot help either.
…calTypesEnabled enabled, * Avro schema is created with logical type uuid.
MichalFoksa
changed the title
Logical type for java.util.UUID
[Avro] Logical type for java.util.UUID
Dec 23, 2024
avro/src/main/java/com/fasterxml/jackson/dataformat/avro/schema/StringVisitor.java
Show resolved
Hide resolved
cowtowncoder
changed the title
[Avro] Logical type for java.util.UUID
Add Logical Type support for Dec 24, 2024
java.util.UUID
cowtowncoder
approved these changes
Dec 24, 2024
Thank you @MichalFoksa ! Merged for inclusion in 2.19.0. |
@cowtowncoder |
PR with Decimal logical type will come later. I think we will need a new annotation to express decimal precision and scale. Probably I will suggest something in PR and we can discuss it. Merry Christmas 🎅 🎄! |
Merry Christmas @MichalFoksa ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logical type
uuid
intojava.util.UUID
Avro schema.Until now UUID schema was:
Now, with logicalTypesEnabled = true, schema is: