[Avro] Add support for @Stringable annotation #53
Conversation
baharclerode
force-pushed
the
bah.StringableAnnotation
branch
from
4afec93 to
f3cb333
Compare
|
|
||
| @Override | ||
| public Object findSerializer(Annotated a) { | ||
| if (a instanceof AnnotatedClass && a.hasAnnotation(Stringable.class) || a.getRawType() == File.class) { |
There was a problem hiding this comment.
First part makes sense I guess, but do we really need File? It's serialized using value.getAbsolutePath() already.
Alternatively if this really needs to be changed, I think we should just register serializer via AvroModule, and not through annotation introspector.
There was a problem hiding this comment.
Avro uses toString() / getPath() instead of getAbsolutePath(), so this was a quick fix to make the behavior match up. I'll replace it with a proper serializer in the module.
|
Hate to to this but... would it be possible to re-base it to |
|
I can rebase this into master. After this, I have two more planned PRs, one for |
|
Closed and reopened against master as #57 |
This adds support for the
@Stringableannotation, and adds support for stringable classes (Those with@Stringable, andURL/URI/File/BigInteger/BigDecimal). This fixes BigInteger/BigDecimal compatibility with the apache implementation.Of particular note,
BigDecimalis no longer aType.DOUBLEin schema generation, nor isBigIntegeraType.LONGin schema generation (since they are "stringable" to avro), but they should continue to serialize/deserialize properly from int/long/float/double scalars in existing avro schemas.I treated
@Stringableon a class as having a creator annotation on the constructor which takes a single string argument. I'm not sure if there is a better way to do this.