-
-
Notifications
You must be signed in to change notification settings - Fork 137
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove tag copying for CBOR event copies.
Copying tags can be dangerous in two main cases: 1. Jackson creates its own tags, such as for BigNum or the self describe tag. 2. The semantic meaning of an element changes. For example, converting between stringrefs and no stringrefs. In some cases it would result in duplicate tags, while in others it may cause completely incorrect tags, such as a stringref tag applying to a string rather than an integer. Before nested tag support was added this could generate files that Jackson could not parse, though even with nested tag support it may cause undefined behavior.
- Loading branch information
1 parent
a5d2895
commit a135e6b
Showing
2 changed files
with
37 additions
and
43 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters