Add tests for Record deserialization regression and related
#3921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JooHyukKim
changed the title
Recrod deser regression and relatedRecord deser regression and related
JooHyukKim
changed the title
Record deser regression and relatedRecord deserialization regression and related
| } | ||
|
|
||
| public void testEmptyJsonToRecordUsingModuleOther() throws JsonProcessingException { | ||
| ObjectMapper mapper = newJsonMapper().registerModule(new SimpleModule() { |
There was a problem hiding this comment.
Could you change this to use mapperBuilder() instead? That way it'll merge cleanly into master.
There was a problem hiding this comment.
Changed all newJsonMapper().registerModule()... to jsonMapperBuilder().addModule().build(). Thank you 🙏🏼
There was a problem hiding this comment.
Could you change this to use
mapperBuilder()instead? That way it'll merge cleanly into master.
Hopefully jsonMapperBuilder() is what you meant, @cowtowncoder ?
cowtowncoder
approved these changes
May 22, 2023
JooHyukKim
deleted the
3906-Add-tests-for-regression-and-to-prepare-for-rewrite
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides all cases (including both regression and work-arounds) mentioned in #3906. Thought it might help for future modification/rewrite of (Record, or property discovery in genenral) that seems to be coming.... 🙏🏼
NOTE: Feel free to close this PR if you think this is unncessary~ ✌️✌️