Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : add EnumFeature.WRITE_ENUMS_TO_LOWERCASE #3776

Conversation

JooHyukKim
Copy link
Member

Summary

@cowtowncoder
Copy link
Member

Thank you @JooHyukKim ! Looks good -- but I realized something reading through it... method isEnabled(DatatypeFeature) SHOULD be accessible via MapperConfig but wasn't yet.
So I went ahead and changed this (see 6c8c151) so it is now there.

So I think you can simplify code by keeping old method signature & not having to deprecate old method.

@JooHyukKim JooHyukKim force-pushed the Fix-#3053-(Serialize-enums-to-lowercase) branch from 1a25399 to 785b4bf Compare February 9, 2023 05:23
@JooHyukKim
Copy link
Member Author

Thank you @JooHyukKim ! Looks good -- but I realized something reading through it... method isEnabled(DatatypeFeature) SHOULD be accessible via MapperConfig but wasn't yet. So I went ahead and changed this (see [6c8c151](https://githu.......

@cowtowncoder Good call! How could I not think of that.

So I think you can simplify code by keeping old method signature & not having to deprecate old method.

Done and tested. 🙏🏼🙏🏼

@cowtowncoder cowtowncoder merged commit 0f0d04c into FasterXML:2.15 Feb 10, 2023
@JooHyukKim JooHyukKim changed the title Feature : add EnumFeature.WRITE_ENUMS_TO_LOWERCASE #3053 #3054 Feature : add EnumFeature.WRITE_ENUMS_TO_LOWERCASE Mar 13, 2023
@JooHyukKim JooHyukKim deleted the Fix-#3053-(Serialize-enums-to-lowercase) branch May 22, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants