Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(2.6) Backport all CVE fixes up to 2.9.10.6 #2864

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

millems
Copy link

@millems millems commented Sep 28, 2020

Motivation: Jackson-2.6 is still widely used, despite being deprecated (including in the AWS SDK for Java 1.11.x). Until those consumers can migrate to a supported version of Jackson-2.6, this patch will protect those customers from the CVEs currently open against 2.6.7.3.

A similar change was made as part of 2.6.7.3 with similar motivation: a3939d3

@millems
Copy link
Author

millems commented Sep 28, 2020

Note: We have long-term plans that prevent these patch backports from being necessary (at least, within the AWS SDK for Java ecosystem), but in the medium term this seems to be the cheapest option for our customers that we can come up with.

@cowtowncoder
Copy link
Member

Happy to merge these, but one thing I will note is that I do not have current plans to make releases from branches prior to 2.9 at this point (2.9 releases will end by end of 2020 as well).
I think some companies release their own versions which might be fine (and having changes in official branch hopefully helps).

I am not dead set against making a release but it is some effort with limited upside. I do note however that at least the latest 2.6 micro-patch (2.6.7.3) is being used by some projects (unlike latest 2.7) so I guess that is something.

@cowtowncoder cowtowncoder merged commit 74aba40 into FasterXML:2.6 Sep 29, 2020
@millems
Copy link
Author

millems commented Sep 29, 2020

Thanks, I really appreciate it. I understand that it's some effort to release old versions of software. We don't have any customers demanding this fix - we're just being proactive with these patching efforts - so we're not asking for a micro-patch to be released.

If customers start demanding it of us (while we work on the long-term plans to move off of 2.6, of course), is there a way we can assist with actually releasing a micro-patch of 2.6?

@cowtowncoder
Copy link
Member

@millems thank you! I wish I knew of a way to delegate some of the access rights but unfortunately at this point I don't think that is easy. What I can do is to create a placeholder issue in which to add notes and do "voting" (whoever would want the release can use thumbs up). I could then consider syncing one-off release with 2.9.10.x micro-patch -- there will be at least one more. Doing both at same time makes things bit more efficient, less context switching and so on.

@cowtowncoder
Copy link
Member

See: #2866 2866

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants