Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking API change in BasicClassIntrospector (2.12.0) #2990

Closed
fdutton opened this issue Dec 17, 2020 · 1 comment
Closed

Breaking API change in BasicClassIntrospector (2.12.0) #2990

fdutton opened this issue Dec 17, 2020 · 1 comment
Milestone

Comments

@fdutton
Copy link
Contributor

fdutton commented Dec 17, 2020

Jackson 2.12 introduced a breaking change for users that have a custom ClassIntrospector.

Version information
2.12.0

Additional context
The method signature for constructPropertyCollector replaced the mutatorPrefix parameter with an AccessorNamingStrategy. This causes a runtime exception when the JVM cannot find the old method on BasicClassIntrospector. Reviewing the code shows several other breaking API changes.

@fdutton fdutton added the to-evaluate Issue that has been received but not yet evaluated label Dec 17, 2020
@cowtowncoder
Copy link
Member

Ok thank you. The original intent was for ClassIntrospector to be the API, and BasicClassIntrospector being implementation but not extension point of its own.
But I can see why in practice developers would be more likely to extend default implementation, and in hindsight it would have made sense to handle this the usual way via deprecation and call chaining.
And in fact some of comments already suggest extensibility ("overridable methods").

@cowtowncoder cowtowncoder added 2.12 and removed to-evaluate Issue that has been received but not yet evaluated labels Dec 18, 2020
cowtowncoder pushed a commit that referenced this issue Dec 18, 2020
@cowtowncoder cowtowncoder changed the title Breaking API change in BasicClassIntrospector Breaking API change in BasicClassIntrospector (2.12.0) Dec 18, 2020
@cowtowncoder cowtowncoder modified the milestones: 1.9.13, 2.12.1 Dec 18, 2020
cowtowncoder added a commit that referenced this issue Dec 18, 2020
cowtowncoder added a commit that referenced this issue Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants