Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MapperFeature.ACCEPT_CASE_INSENSITIVE_ENUMS should work for enum as keys #2873

Closed
XakepSDK opened this issue Oct 8, 2020 · 6 comments
Closed

MapperFeature.ACCEPT_CASE_INSENSITIVE_ENUMS should work for enum as keys #2873

XakepSDK opened this issue Oct 8, 2020 · 6 comments
Labels
hacktoberfest Issue related to Hactoberfest activities, eligible for additional rewards
Milestone
2.12.0

Comments

@XakepSDK
Copy link
Contributor

XakepSDK commented Oct 8, 2020

Describe the bug
ACCEPT_CASE_INSENSITIVE_ENUMS not working for enums as map keys

Version information
2.11.2

To Reproduce
Use enum as map key and deserialize json with different key case

Expected behavior
ACCEPT_CASE_INSENSITIVE_ENUMS works for map enum keys
@XakepSDK XakepSDK added the to-evaluate Issue that has been received but not yet evaluated label Oct 8, 2020
@cowtowncoder cowtowncoder added good first issue Issue that seems easy to resolve and is likely a good candidate for contributors new to project hacktoberfest Issue related to Hactoberfest activities, eligible for additional rewards labels Oct 9, 2020
@cowtowncoder cowtowncoder changed the title ACCEPT_CASE_INSENSITIVE_ENUMS for enum as keys MapperFeature.ACCEPT_CASE_INSENSITIVE_ENUMS should work for enum as keys Oct 9, 2020
@cowtowncoder cowtowncoder added good first issue Issue that seems easy to resolve and is likely a good candidate for contributors new to project and removed good first issue Issue that seems easy to resolve and is likely a good candidate for contributors new to project to-evaluate Issue that has been received but not yet evaluated labels Oct 9, 2020
@ILGO0413
Copy link
Contributor

ILGO0413 commented Oct 9, 2020

I would like to work on it.

@ILGO0413
Copy link
Contributor

ILGO0413 commented Oct 9, 2020

According to README.md#Basic rules for Code Contributions, I should provide a filled Contributor License Agreement. Do you have any example of CLA?

@ILGO0413 ILGO0413 mentioned this issue Oct 9, 2020
Merged
@cowtowncoder
Copy link
Member

@ILGO0413 yes, it's under "FasterXML/jackson" repo:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and the easiest way is probably to print, fill & sign, scan/photo, email to info at fasterxml dot com.

@ILGO0413
Copy link
Contributor

Would you accept it if I write it by hand?

@cowtowncoder
Copy link
Member

CLA as submitted fine (i.e. electronic variant works for us). Thank you for doing it very quickly!

cowtowncoder pushed a commit that referenced this issue Oct 11, 2020
@ILGO0413 @cowtowncoder
Fix #2873: Added case sensitivity check flag from MapperConfig to Enu…
85edd63 
…mResolver
@cowtowncoder cowtowncoder added this to the 2.12.0 milestone Oct 11, 2020
@cowtowncoder
Copy link
Member

Merged, backported in 2.12. Thank you @ILGO0413!

@cowtowncoder cowtowncoder removed the good first issue Issue that seems easy to resolve and is likely a good candidate for contributors new to project label Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest Issue related to Hactoberfest activities, eligible for additional rewards
Projects
None yet
Milestone
2.12.0
Development

No branches or pull requests
3 participants
@cowtowncoder @XakepSDK @ILGO0413