Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convertValue() api contract now different #166

Closed
cheddar opened this issue Feb 13, 2013 · 3 comments
Closed

convertValue() api contract now different #166

cheddar opened this issue Feb 13, 2013 · 3 comments

Comments

@cheddar
Copy link
Contributor

cheddar commented Feb 13, 2013

convertValue(List, List.class)

Used to generate

List<Map<String, Object>>

Now it's returning

List

I.e. it's just returning the first argument.

@cowtowncoder
Copy link
Member

Ah. It's a minor flaw, so that if you pass JavaType, proper checks are made to avoid simple cast for types with generic arguments (like List or Map); but this is NOT done if passing argument as Class.

So: I will fix this; but there is also a work-around -- just create JavaType out of Class, pass that, and behavior should remain the same.

@cowtowncoder
Copy link
Member

And I think this is related to #11 (caused by it, missing check from one codepath)

cowtowncoder added a commit that referenced this issue Feb 13, 2013
cowtowncoder added a commit that referenced this issue Feb 13, 2013
@cowtowncoder
Copy link
Member

Fixed.

christophercurrie pushed a commit to christophercurrie/jackson-databind that referenced this issue Jul 19, 2015
Allow to configure line endings and indentation
christophercurrie pushed a commit to christophercurrie/jackson-databind that referenced this issue Jul 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants