Skip to content

Commit

Permalink
Mark #4742 as fixed as well; move now-passing test to proper place
Browse files Browse the repository at this point in the history
  • Loading branch information
cowtowncoder committed Nov 13, 2024
1 parent a8b4bc3 commit c61bbba
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
4 changes: 4 additions & 0 deletions release-notes/CREDITS-2.x
Original file line number Diff line number Diff line change
Expand Up @@ -1846,6 +1846,10 @@ wrongwrong (@k163377)
on the pre-converted value when _delegateSerializer was null
(2.18.1)

Bernd Ahlers (@bernd)
* Reported #4742: Deserialization with Builder, External type id, `@JsonCreator` failing
(2.18.2)

Mike Minicki (@martel)
* Reported #4788: `EnumFeature.WRITE_ENUMS_TO_LOWERCASE` overrides `@JsonProperty` values
(2.18.2)
2 changes: 2 additions & 0 deletions release-notes/VERSION-2.x
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ Project: jackson-databind

#4733: Wrong serialization of Type Ids for certain types of Enum values
(reported by @nlisker)
#4742: Deserialization with Builder, External type id, `@JsonCreator` failing
(reported by Bernd A)
#4777: `StdValueInstantiator.withArgsCreator` is now set for creators with
no arguments
(reported by @wrongwrong)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.fasterxml.jackson.databind.tofix;
package com.fasterxml.jackson.databind.deser.builder;

import java.util.List;

Expand All @@ -17,8 +17,8 @@
import static org.junit.jupiter.api.Assertions.assertInstanceOf;

// [databind#4742] Deserialization with Builder, External type id,
// @JsonCreator not yet implemented
public class JacksonBuilderCreatorSubtype4742Test
// @JsonCreator failing
public class BuilderCreatorSubtype4742Test
extends DatabindTestUtil
{
public static class Animals {
Expand Down Expand Up @@ -125,6 +125,5 @@ public void testDeser() throws Exception
assertEquals(2, animals.animals.size());
assertInstanceOf(BirdProperties.class, animals.animals.get(0).properties);
assertInstanceOf(MammalProperties.class, animals.animals.get(1).properties);

}
}

0 comments on commit c61bbba

Please sign in to comment.