Fix ArrayIndexOutofBoundsException found by LGTM.com #510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seen on LGTM.com here
As
codes.length == maxCode
so ifi == maxCode
anArrayIndexOutOfBoundsException
is thrown. This happens whenALLOW_UNQUOTED_FIELD_NAMES
is enabled and character256
is found as part of a field name after needing to consume more data from the reader.A gist containing code to trigger this path can be found here. I could find any tests for this class but if there is a place to add tests I can add the example as a test.
(Full disclosure: I'm part of the company behind LGTM.com)