Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change parsing error message to mention -INF #1136

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

pjfanning
Copy link
Member

-INF is allowed.

The code is unclear about whether 'INF' is allowed. '+INF' seems to be tested and seems to work but 'INF' seems to be documented but I'm not sure if it works.

@cowtowncoder
Copy link
Member

That sounds reasonable if correct; but let me try to have a look first... definitely needs to include -INF

@cowtowncoder
Copy link
Member

Hmmmh. So, tests in com.fasterxml.jackson.core.read.NonStandardParserFeaturesTest check for content:

        final String JSON = "[ -INF, +INF, +Infinity, Infinity, -Infinity ]";

which does NOT include INF but does full versions. ReaderBasedJsonParser appears to (maybe?) accept it.
Test mentioned above does fail on INF for what that is worth.

So I think I'll go with this.

@cowtowncoder cowtowncoder changed the title change error message to mention -INF Change parsing error message to mention -INF Nov 8, 2023
@cowtowncoder cowtowncoder merged commit a0c853a into FasterXML:2.16 Nov 8, 2023
5 checks passed
cowtowncoder added a commit that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants