Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Black Lint with github actions #278

Merged
merged 3 commits into from
Jan 7, 2024
Merged

Black Lint with github actions #278

merged 3 commits into from
Jan 7, 2024

Conversation

Dragorn421
Copy link
Contributor

Use github actions to automatically check if code has been black-formatted

Can be seen in action here: Dragorn421#3

Of course we want #277 merged first

@Dragorn421 Dragorn421 added the codebase Code maintenance/cleanup label Jan 6, 2024
@Dragorn421 Dragorn421 force-pushed the main branch 2 times, most recently from b76be22 to 62349da Compare January 6, 2024 12:50
@Yanis002
Copy link
Contributor

Yanis002 commented Jan 6, 2024

finally github actions here 🙏

@Dragorn421 Dragorn421 marked this pull request as ready for review January 7, 2024 12:51
Yanis002
Yanis002 approved these changes Jan 7, 2024
View reviewed changes
Copy link
Contributor

@Yanis002 Yanis002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is working on your branch and it comes from the official documentation I see no reason to hold this from merge

@Yanis002 Yanis002 added the merge soon Will be merged in a few days at most if nothing else comes up label Jan 7, 2024
@Dragorn421 Dragorn421 merged commit cad6560 into Fast-64:main Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yanis002 Yanis002 Yanis002 approved these changes

Assignees
No one assigned
Labels
codebase Code maintenance/cleanup merge soon Will be merged in a few days at most if nothing else comes up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dragorn421 @Yanis002