Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix onPressActionButton not being called #2561

Merged

Conversation

Ksm125
Copy link
Contributor

@Ksm125 Ksm125 commented Nov 30, 2024

This add the onPressActionButton as props to Actions elements

Fix #2560

@kesha-antonov
Copy link
Collaborator

@Ksm125
Copy link
Contributor Author

Ksm125 commented Feb 25, 2025

Hi

Doesn't understand why it's need since we already use this prop

https://github.com/FaridSafi/react-native-gifted-chat/blob/master/src/InputToolbar.tsx#L30

https://github.com/FaridSafi/react-native-gifted-chat/blob/master/src/InputToolbar.tsx#L55

Hello @kesha-antonov ,

Well in fact this prop exists but it is not passed (at least not anymore) to the renderActions or Actions.
When we create the props we do not have the onPressActionButton value in that object whereas in the previous library version, I have access to it within my component renderActions. Or is it what we expect now?

Screenshot 2025-02-25 at 11 07 22

https://github.com/FaridSafi/react-native-gifted-chat/blob/master/src/InputToolbar.tsx#L51

@kesha-antonov kesha-antonov merged commit 2cbd825 into FaridSafi:master Feb 25, 2025
@kesha-antonov
Copy link
Collaborator

Understood what you meant
Thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onPressActionButton is not anymore passed to renderActions or Actions component
2 participants