Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different working directories for data #7

Merged
merged 9 commits into from
May 27, 2021
Merged

Support different working directories for data #7

merged 9 commits into from
May 27, 2021

Conversation

guilherme-fh
Copy link
Contributor

@guilherme-fh guilherme-fh commented May 26, 2021

PR Details

  • Adds chooseFolder method to Utils to give support to directory selection
  • Defines workingDirectory that is defined according to what's set on the dataFolder.json (or else defaults to the root directory). Upon setting a new workingDirectory the dataFolder.json is updated accordingly
  • Adds a section to the Options screen to display the working directory and a button to change said directory which updates workingDirectory

Description

This PR intends to give support to different working directories to access the data and test files.
Its purpose is to allow git synchronisation of these files, a feature that useful when working with teams.

Motivation and Context

This PR intends to ease synchronisation of data and test files among large (or even small) teams

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

src/Mockingbird/Utils/Default.swift Show resolved Hide resolved
src/Mockingbird/Utils/Default.swift Outdated Show resolved Hide resolved
src/Mockingbird/UI/View/OptionsView.swift Outdated Show resolved Hide resolved
src/Mockingbird/AppDelegate.swift Outdated Show resolved Hide resolved
@erickjung erickjung merged commit 8981a5d into Farfetch:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants