-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Umshini: update environments to use OpenAI 1.0.0 API, add CI testing #98
Merged
elliottower
merged 111 commits into
Farama-Foundation:dev
from
elliottower:umshini-openai-v1-update
Nov 22, 2023
Merged
Umshini: update environments to use OpenAI 1.0.0 API, add CI testing #98
elliottower
merged 111 commits into
Farama-Foundation:dev
from
elliottower:umshini-openai-v1-update
Nov 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Umshini environment updates (merge dev to master branch)
…-workflow Add python-publish workflow to automate pypi releases
…'t possible to include there
…ws only detect 4 tests
…not to run if not
…v from macos test (fails)
Okay these environment variables and adding the keys to CI is seeming to be a way bigger pain than I thought it would be, going to test on a private repo to see if I can get it working (don't want to publicly print an API key here in a workflow) |
…pdate # Conflicts: # pyproject.toml
Changed the base to dev which is a bit messy but I don't want to mess up main branch, will just work on the dev one and see if I can get it to work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also allows us to do proper testing of the regular environments, which I have added to the same CI workflow.
The AzureOpenAI workflow is exclusive to these Umshini environments, and I have added our deployment and info to the repository secrets, it just makes things easier on our end to test here and make sure that it will work with both OpenAI and AzureOpenAI (less back and forth fixing minor bugs and making new releases)