Remove pz classic requirement from umshini, slight bugfix in envs #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Now this PR is merged and released as v0.1.12.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor but important PR, as it turns out having
pettingzoo[classic]as a requirement results in bothpygameandpygame-cebeing installed, which then leads to issues due to ambiguous imports. Also fixes an edge case which wasn't accounted for in the original code.Note: I think the pyproject.toml should be removed entirely, or setup.py should be removed entirely in favor of pyproject. Having them both is redundant and is super confusing: I previously changed pyproject, without realizing the install actually used setup.py, the extras names on pyproject are also not fully consistent: there's still ones called
langchain_requirementsandumshini_requirementsrather thanumshini.