fix render_mode attribute not being set by sb3 wrapper. #242
Conversation
Added a test to record video
There was a problem hiding this comment.
Sorry but this should be in a separate class or file, SB3 is does not officially support pettingzoo at all, even though it does work we can’t guarantee anything. RGB array rendering means it saves it as a numpy object, so we still want the existing test, but also testing that SB3 works is fine I suppose as well. I may make another PR though making these wrappers more similar to pettingzoo where they inherit all of the underlying env properties, rather than just the render mode and ones we specify.
There was a problem hiding this comment.
Ok so won't merge this one but rather merge your enhanced sb3 wrapper ?
Let me know if we should just close this and let me add the test to your PR
There was a problem hiding this comment.
I honestly don't remember what I did with the SB3 wrapper, I think it's fine to test something with SB3 as you do here, but it needs to be in addition to the previous test, not replacing the previous one.
I will look into the changes Florian made to PettingZoo to fix the attributes inheritance and such, and see if it's possible to do here
There was a problem hiding this comment.
Ok cool.
But I'm not replacing any tests here. The only one that was here was already commented because it fails. I updated the code to match the latest SS version but it still failed.
There was a problem hiding this comment.
Oh I see, hmm well in that case we should probably try to make that test not fail in an ideal world at least
There was a problem hiding this comment.
Agreed but I think it is outside the scope of this PR as it is not related to the attribute erasing (see the below error message)
X connection to :0 broken (explicit kill or server shutdown).
XIO: fatal IO error 2 (No such file or directory) on X server ":0"
after 88 requests (88 known processed) with 0 events remaining.
XIO: fatal IO error 2 (No such file or directory) on X server ":0"
after 88 requests (88 known processed) with 0 events remaining.There was a problem hiding this comment.
Oh that's bizarre... alright well fair enough I guess this is better than nothing
|
Could you run pre-commit hooks? |
|
Also you'll need to add stable-baselines3 as a testing requirement |
|
I made my own PR fixing these things so no worries (faster for me to do now and then merge it while I'm working today) |
|
See #243 |
Also added a test to record video. This test currently creates 2 files in /tmp, should I remove them after the test or is that ok ?
Fix #241