Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: have access to terminal_observation in the infos. #233

Merged
merged 8 commits into from
Nov 28, 2023
Merged

fix: have access to terminal_observation in the infos. #233

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
65086cf
fix: have access to `terminal_observation` in the infos.
KaleabTessera Oct 30, 2023
ba3299d
fix: fix empty reset_infs.
KaleabTessera Oct 30, 2023
7096918
feat: Ensure infos list is of size n agents.
KaleabTessera Nov 6, 2023
9788c66
feat: test terminal_obs are returned when env reset.
KaleabTessera Nov 6, 2023
344ee29
fix: add black death wrapper to test.
KaleabTessera Nov 7, 2023
20af522
fix: ensure parallel vec env don't reset using same seed.
KaleabTessera Nov 19, 2023
bc36bdf
fix: remove debugging code.
KaleabTessera Nov 19, 2023
e49c5e1
fix: remove manual seeding if seed is none.
KaleabTessera Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion supersuit/vector/markov_vector_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,14 @@ def step(self, actions):
infs = [infos.get(agent, {}) for agent in self.par_env.possible_agents]

if env_done:
observations, infs = self.reset()
observations, reset_infs = self.reset()
else:
observations = self.concat_obs(observations)
# empty infos for reset infs
reset_infs = [{} for _ in range(len(self.par_env.possible_agents))]
# combine standard infos and reset infos
infs = infs + reset_infs
elliottower marked this conversation as resolved.
Show resolved Hide resolved

assert (
self.black_death or self.par_env.agents == self.par_env.possible_agents
), "MarkovVectorEnv does not support environments with varying numbers of active agents unless black_death is set to True"
Expand Down
Loading