Fix truncations logic error in base_aec_wrapper.py (#247)

Farama-Foundation · Mar 13, 2024 · ed2641e · ed2641e
1 parent 6e1f348
commit ed2641e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/supersuit/utils/base_aec_wrapper.py b/supersuit/utils/base_aec_wrapper.py
@@ -40,7 +40,7 @@ def observe(self, agent):
 
     def step(self, action):
         agent = self.env.agent_selection
-        if not self.terminations[agent] or self.truncations[agent]:
+        if not (self.terminations[agent] or self.truncations[agent]):
             action = self._modify_action(agent, action)
 
         super().step(action)

diff --git a/test/pettingzoo_env_test.py b/test/pettingzoo_env_test.py
@@ -0,0 +1,11 @@
+from pettingzoo.mpe import simple_spread_v3
+from pettingzoo.test import parallel_api_test
+
+from supersuit.multiagent_wrappers import pad_action_space_v0
+
+
+def test_pad_actuon_space():
+    env = simple_spread_v3.parallel_env(max_cycles=25, continuous_actions=True)
+    env = pad_action_space_v0(env)
+
+    parallel_api_test(env, num_cycles=100)