-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update chess to v6, fix all envs to render at correct FPS, clean up pygame code #999
Merged
elliottower
merged 13 commits into
Farama-Foundation:master
from
elliottower:classic-render-fps
Jun 17, 2023
Merged
Update chess to v6, fix all envs to render at correct FPS, clean up pygame code #999
elliottower
merged 13 commits into
Farama-Foundation:master
from
elliottower:classic-render-fps
Jun 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r_fps, fix flipped chess board
This ended up being a large number of changes in one PR so apologies for that, just figured I'd do pretty much all of the pygame related fixes here. |
Cooperative pong had some very weird bugs due to the observations using pygame as well as the rendering, but the tests now pass locally so I think it should be good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an issue in the discord about chess having the wrong first player, turns out the issue was a typo relating to the rendering images. I also normalized all of the classic environments to actually tick according to their specified render FPS, as most of them just ran as fast as possible despite saying they had a given FPS.
This will likely mean all of them will have to use EzPickle, but I'm waiting until that test fails to change it.
Edit: they did not fail because the pickle test did not use render mode human, therefore the pygame clock was not initialized, but I figure we might as well check that things can be pickled no matter what. Previously in shimmy I had some issues pickling rendered environments, so it's good that this works. I think if you try to pickle and unpickle an env it doesn't directly work with rendering naively but I think you can do env.reset() and it will work?
Not sure if we can do a warning if people try to pickle rendered envs, maybe it's fine to just tell them not to do that.
Fixes # (issue), Depends on # (pull request)
Type of change
Screenshots
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)pytest -v
and no errors are present.pytest -v
has generated that are related to my code to the best of my knowledge.