Fix classic environments screen sizes, add type hints, fix pre-commit #998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added screen_height argument to the rlcard envs and RPS env (they have dynamic widths depending on number of players, i used a slightly smaller default height for RPS as it was 350 previously, whereas rlcard was 1000px), added screen_scaling to connect_four because the rendering in that environment is a bit finnicky and only works for certain resolutions (the original ratio is 99 / 86, and any resolutions which multiple both numbers by integers work, but scaling by 2.5 for example results in white space because of rounding), and added screen_height to chess and go (originally used screen_width but it's simpler to have only two args to try out: screen_height for some envs, or for connect four it's screen_scaling, rather than having to remember 3 different ones for different envs)
I also added type hints to the classic envs as I was already going through and adding new args.
Almost all of the files had # noqa which ignores checks on the files globally (i.e., when doing new code it didn't even re-format according to black unless you removed the line), so I replaced that with specific ignores for the two pydocstring errors which are a result of us using the large docstrings at the top of environments to dynamically create the environment pages (starting with an H1 tag instead of full sentence with period).
I did change the default size of RPS to be bigger and go and connect to be slightly smaller and more normalized with everything else, but didn't change underlying envrionments so don't think it should need a new version
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue), Depends on # (pull request)
Type of change
Screenshots
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)pytest -v
and no errors are present.pytest -v
has generated that are related to my code to the best of my knowledge.