Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.23.0 and update tutorial requirements #984

Merged
merged 17 commits into from
May 15, 2023

Conversation

elliottower
Copy link
Contributor

Description

Bump version for 1.23.0 release

Fixes # (issue), Depends on # (pull request)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.
To upload images to a PR -- simply drag and drop or copy paste.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@elliottower
Copy link
Contributor Author

This PR will fail until 1.23.0 is released, but in the second to last commit you can see that every test besides Ray works with the most recent master install of PettingZoo, indicating that when we create the 1.23.0 release these tests should pass. We could keep them locked to the most recent master version of PettingZoo, which I think would make things simpler, and allow for future updates to the tutorials more easily, but I suppose in the case that we do need to update the tutorials and not do a release, we can change the requirements to explicitly do github master, otherwise we keep it like this for simplicity.

@elliottower elliottower merged commit bb9625f into Farama-Foundation:master May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant