Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Tianshou tutorial and dependencies #980

Merged

Conversation

elliottower
Copy link
Contributor

@elliottower elliottower commented May 12, 2023

Description

Minor fix so that the most recent version of tianshou works with the tutorial (tested locally).

Edit: it worked the first time but now for some reason I'm running into errors.

When running 2_training_agents.py I got this error:

/Users/elliottower/anaconda3/envs/pettingzoo/lib/python3.8/site-packages/torch/utils/tensorboard/init.py:4: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
if not hasattr(tensorboard, "version") or LooseVersion(
Traceback (most recent call last):
File "2_training_agents.py", line 18, in
from tianshou.data import Collector, VectorReplayBuffer
File "/Users/elliottower/anaconda3/envs/pettingzoo/lib/python3.8/site-packages/tianshou/init.py", line 1, in
from tianshou import data, env, exploration, policy, trainer, utils
File "/Users/elliottower/anaconda3/envs/pettingzoo/lib/python3.8/site-packages/tianshou/data/init.py", line 21, in
from tianshou.data.collector import Collector, AsyncCollector
File "/Users/elliottower/anaconda3/envs/pettingzoo/lib/python3.8/site-packages/tianshou/data/collector.py", line 18, in
from tianshou.env import BaseVectorEnv, DummyVectorEnv
File "/Users/elliottower/anaconda3/envs/pettingzoo/lib/python3.8/site-packages/tianshou/env/init.py", line 18, in
from tianshou.env.pettingzoo_env import PettingZooEnv
File "/Users/elliottower/anaconda3/envs/pettingzoo/lib/python3.8/site-packages/tianshou/env/pettingzoo_env.py", line 11, in
if version.parse(pettingzoo.version) < version.parse("1.21.0"):
AttributeError: module 'pettingzoo' has no attribute 'version'

Edit2: Looks like with version 0.5.0 this is fixed and the CI tests seem to work

Fixes # (issue), Depends on # (pull request)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.
To upload images to a PR -- simply drag and drop or copy paste.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@elliottower elliottower merged commit bd70923 into Farama-Foundation:master May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant