Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update environment creation tutorial with accurate obs/action space usage #972

Merged
merged 7 commits into from
May 12, 2023

Conversation

elliottower
Copy link
Contributor

Description

Minor update addressing a question in discord about the usage of env.action_spaces (which is deprecated in favor of the env.action_space(agent) method).

Fixes # (issue), Depends on # (pull request)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.
To upload images to a PR -- simply drag and drop or copy paste.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@elliottower elliottower requested a review from jjshoots May 12, 2023 04:24
@elliottower
Copy link
Contributor Author

Want a second pair of eyes to confirm this looks good. Not much changes but for example render_mode I believe should be set in init but it wasn't listed as a required thing previously. I guess technically you can ignore it?

@jjshoots jjshoots assigned jjshoots and unassigned jjshoots May 12, 2023
@jjshoots
Copy link
Member

Will look at this a little later. Messaging here to subscribe.

Copy link
Member

@jjshoots jjshoots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes, makes more sense and is more up to date. But imho some things can be worded better, other than that, LGTM.

@elliottower elliottower merged commit 81c4d9c into master May 12, 2023
@elliottower elliottower deleted the elliottower-patch-7 branch May 12, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants