-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update environment creation tutorial with accurate obs/action space usage #972
Conversation
Want a second pair of eyes to confirm this looks good. Not much changes but for example render_mode I believe should be set in init but it wasn't listed as a required thing previously. I guess technically you can ignore it? |
Will look at this a little later. Messaging here to subscribe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes, makes more sense and is more up to date. But imho some things can be worded better, other than that, LGTM.
Description
Minor update addressing a question in discord about the usage of env.action_spaces (which is deprecated in favor of the env.action_space(agent) method).
Fixes # (issue), Depends on # (pull request)
Type of change
Screenshots
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)pytest -v
and no errors are present.pytest -v
has generated that are related to my code to the best of my knowledge.